Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Rename md parameters for consistency #8244

Merged
merged 1 commit into from
Mar 8, 2023
Merged

🌱 Rename md parameters for consistency #8244

merged 1 commit into from
Mar 8, 2023

Conversation

killianmuldoon
Copy link
Contributor

Update MachineDeployment parameter names (d -> md) to make them more consistent across the codebase.

/kind cleanup
/area code-organization

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. area/code-organization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 7, 2023
killianmuldoon
killianmuldoon commented Mar 7, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is a follow up for https://github.com/kubernetes-sigs/cluster-api/pull/7509/files#r1016472426

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 53f2ab5206dc14a57b43994142b1cfff6c7828b1

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sbueringer March 7, 2023 12:25
@sbueringer
Copy link
Member

Note: this is a follow up for https://github.com/kubernetes-sigs/cluster-api/pull/7509/files#r1016472426

I already forgot this 😃

@killianmuldoon
Copy link
Contributor Author

I already forgot this

Probably no the highest priority change, but I'm closing that PR so I wanted to make sure this was covered over somewhere.

@richardcase
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d547e90ee41a863a198fce3a92852482a159efb7

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit 838dcbb into kubernetes-sigs:main Mar 8, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jont828 Jont828 Awaiting requested review from Jont828

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@richardcase richardcase

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@killianmuldoon @sbueringer @k8s-ci-robot @richardcase