Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the resync interval to 10m, instead of the default 10h #824

Merged
merged 1 commit into from
Mar 27, 2019

Conversation

detiber
Copy link
Member

@detiber detiber commented Mar 18, 2019

What this PR does / why we need it:
Overrides the default resync interval (10h) to 10m

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to: #748

Release note:

The resync interval for reconciling MachineSets and MachineDeployments is now 10m instead of the Kubebuilder default of 10h

/milestone v1alpha1
/assign @vincepri

@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Mar 18, 2019
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 18, 2019
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 18, 2019
@detiber
Copy link
Member Author

detiber commented Mar 18, 2019

/assign @enxebre

@k8s-ci-robot
Copy link
Contributor

@detiber: GitHub didn't allow me to assign the following users: enxebre.

Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @enxebre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 18, 2019
@detiber
Copy link
Member Author

detiber commented Mar 18, 2019

/assign @hardikdr @alvaroaleman

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2019
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/milestone v1alpha1

I'll go ahead and merge this PR given that it has been open for more than a week and it's a simple addition to the manager/main.go file.

@k8s-ci-robot k8s-ci-robot merged commit a1bfbd3 into kubernetes-sigs:master Mar 27, 2019
@detiber detiber deleted the syncInterval branch April 2, 2019 17:44
serbrech pushed a commit to serbrech/cluster-api that referenced this pull request Apr 8, 2019
enxebre pushed a commit to enxebre/cluster-api that referenced this pull request May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants