Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add cloud-provider-azure helm install to quickstart #8239

Merged
merged 1 commit into from
Mar 7, 2023
Merged

📖 Add cloud-provider-azure helm install to quickstart #8239

merged 1 commit into from
Mar 7, 2023

Conversation

CecileRobertMichon
Copy link
Contributor

What this PR does / why we need it: In the upcoming v1.8.0 CAPZ release, the published flavor artifacts will no longer be using the in-tree cloud-provider which means anyone using those templates (including those following the CAPI quickstart) need to take an extra step to install the external cloud-provider. I expect this to become a common need as more providers switch to "external" cloud-provider by default so this adds a new section in the quickstart that others can add to.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2023
@CecileRobertMichon CecileRobertMichon changed the title Add cloud-provider-azure helm install to quickstart 📖 Add cloud-provider-azure helm install to quickstart Mar 6, 2023
dtzar
dtzar approved these changes Mar 6, 2023
View reviewed changes
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
@CecileRobertMichon CecileRobertMichon force-pushed the quick-start-oot-cloud-provider branch from d036222 to da1083c Compare March 6, 2023 23:18
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 6, 2023
jackfrancis
jackfrancis approved these changes Mar 6, 2023
View reviewed changes
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0d1756370cdff7d7675769dd946da3c16ce89360

sbueringer
sbueringer reviewed Mar 7, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thx for adding this.

In the past I saw some providers adding the cloud-provider to their cluster-template with a ClusterResourceSet. But it seems cleaner to install it separately

docs/book/src/user/quick-start.md Show resolved Hide resolved
sbueringer
sbueringer reviewed Mar 7, 2023
View reviewed changes
docs/book/src/user/quick-start.md
Install the official cloud-provider-azure Helm chart on the workload cluster:

```bash
helm install --kubeconfig=./capi-quickstart.kubeconfig --repo https://raw.githubusercontent.com/kubernetes-sigs/cloud-provider-azure/master/helm/repo cloud-provider-azure --generate-name --set infra.clusterName=capi-quickstart --set cloudControllerManager.clusterCIDR="192.168.0.0/16"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Is there some sort of compatibility matrix between the cloud provider and Kubernetes? Or is the cloud provider just compatible with all Kubernetes versions or does the Helm chart take care of this? (or ~ good enough for quickstart)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is, and the Helm chart takes care of it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@sbueringer
Copy link
Member

/lgtm

killianmuldoon
killianmuldoon approved these changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4350c44 into kubernetes-sigs:main Mar 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Mar 7, 2023
@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.2

@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: #8239 failed to apply on top of branch "release-1.2":

Applying: Add cloud-provider-azure helm install to quickstart
Using index info to reconstruct a base tree...
M	docs/book/src/user/quick-start.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/user/quick-start.md
CONFLICT (content): Merge conflict in docs/book/src/user/quick-start.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Add cloud-provider-azure helm install to quickstart
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 7, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #8248

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@dtzar dtzar dtzar approved these changes

@jackfrancis jackfrancis jackfrancis approved these changes

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@jackfrancis jackfrancis

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
7 participants
@CecileRobertMichon @k8s-ci-robot @sbueringer @killianmuldoon @k8s-infra-cherrypick-robot @jackfrancis @dtzar