Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Clarify condition message for unreconciled clusterclass #8202

Merged
merged 1 commit into from
Feb 28, 2023
+2 −2
Merged

🌱 Clarify condition message for unreconciled clusterclass #8202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/controllers/topology/cluster/conditions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func (r *Reconciler) reconcileTopologyReconciledCondition(s *scope.Scope, cluste
clusterv1.TopologyReconciledCondition,
clusterv1.TopologyReconciledClusterClassNotReconciledReason,
clusterv1.ConditionSeverityInfo,
"ClusterClass is outdated. If this condition persists please check ClusterClass status.",
"ClusterClass not reconciled. If this condition persists please check ClusterClass status.",
),
)
return nil
Expand Down
2 changes: 1 addition & 1 deletion internal/controllers/topology/cluster/conditions_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func TestReconcileTopologyReconciledCondition(t *testing.T) {
},
wantConditionStatus: corev1.ConditionFalse,
wantConditionReason: clusterv1.TopologyReconciledClusterClassNotReconciledReason,
wantConditionMessage: "ClusterClass is outdated. If this condition persists please check ClusterClass status.",
wantConditionMessage: "ClusterClass not reconciled. If this condition persists please check ClusterClass status.",
wantErr: false,
},
{
Expand Down