-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix git config in release-binary builds #8199
🐛 Fix git config in release-binary builds #8199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cherry-pick release-1.3
/cherry-pick release-1.3 |
@ykakarap: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: eab425950223126eb3f771370146cb2f885127e5
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
@ykakarap: new pull request created: #8200 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Context on the root cause from slack To follow up on the build issues from yesterday's release. The issue was with the version of git used in the build image golang:1.19.6. It was introduced as a CVE fix in golang:1.19.5 with a debian patch to the version of git installed in that release:
This was fixed temporarily by adding the
|
Sounds good! @ykakarap @killianmuldoon Thx for investigating this issue! @killianmuldoon maybe let's mention it in the office hours to give them an advance warning |
This change fixes a build error in CAPI for release binaries.
When trying to cut a tag for CAPI release v1.4.0 we saw the following error:
This seems to be down to ownership of the directories in the golang container and git being careful about which directories it allows.
I'm still trying to get to the bottom of this issue, but this change seems low impact and should fix the error in the short term to unblock a release.