Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 test/extension: push to staging registry #8181

Merged

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
This PR modifies our push targets to also push the test extension image to the staging repository (just like CAPD).

With this change it will be possible (again) to just run e2e tests locally without having to build the test extension every time.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 27, 2023
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @killianmuldoon

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 27, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine with this - but as I remember this was discussed previously and decided against - what's the reason for pushing this image now?

@sbueringer
Copy link
Member Author

sbueringer commented Feb 27, 2023

Fine with this - but as I remember this was discussed previously and decided against - what's the reason for pushing this image now?

I think it was just discussed between us too :) (and I don't remember details from then to be honest)

The reasons why I would do it now are:

  • it became really annoying to always have to build the test/extension image locally before being able to run the e2e tests (including that building the image changes source files)
  • I think sooner or later we will have a CAPD quickstart which also covers RuntimeSDK and thus the test extension

Makefile Outdated Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-push-test-extension branch from 01993b4 to 2b9c6a0 Compare February 27, 2023 16:34
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 97e9986783d57db28d286219832434b8485fe466

@sbueringer
Copy link
Member Author

/retest

@killianmuldoon
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8ef2ee4 into kubernetes-sigs:main Feb 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 28, 2023
@sbueringer sbueringer deleted the pr-push-test-extension branch February 28, 2023 10:08
@sbueringer
Copy link
Member Author

Verified that the image is available and local e2e test now works without building the image manually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants