-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 test/extension: push to staging registry #8181
🌱 test/extension: push to staging registry #8181
Conversation
/assign @fabriziopandini @killianmuldoon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine with this - but as I remember this was discussed previously and decided against - what's the reason for pushing this image now?
I think it was just discussed between us too :) (and I don't remember details from then to be honest) The reasons why I would do it now are:
|
Signed-off-by: Stefan Büringer [email protected]
01993b4
to
2b9c6a0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks!
LGTM label has been added. Git tree hash: 97e9986783d57db28d286219832434b8485fe466
|
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Verified that the image is available and local e2e test now works without building the image manually. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR modifies our push targets to also push the test extension image to the staging repository (just like CAPD).
With this change it will be possible (again) to just run e2e tests locally without having to build the test extension every time.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #