-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add template metadata to CABPK and KCP types #8180
Conversation
/assign @fabriziopandini |
89a59c8
to
1a3a48f
Compare
1a3a48f
to
2474484
Compare
2474484
to
879a8c6
Compare
879a8c6
to
03b55b9
Compare
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add the ObjectMeta back to the implementers guide in the book? i.e. on this page: https://cluster-api.sigs.k8s.io/developer/providers/bootstrap.html
ref: https://github.com/kubernetes-sigs/cluster-api/pull/6935/files#r923255539
Signed-off-by: Stefan Büringer [email protected]
03b55b9
to
51f4450
Compare
Done |
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: c2dfcc0c8d269c9395599f45c2c6608243babfd9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR adds metadata in the following places:
This is a prepartion for the upcoming PR to test propagation.
Based on the proposal these fields should be propagated but they don't exist today: https://github.com/kubernetes-sigs/cluster-api/blob/main/docs/proposals/images/in-place-propagation/proposed-changes.png
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #