🌱 CAPD: add env var to allow using remote Docker engines #8177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
cncf-cla: yes
|
/assign @fabriziopandini |
|
/assign @killianmuldoon |
killianmuldoon
approved these changes
Feb 27, 2023
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 57181e7f8b2c1080f586dcdd4afd6bac713bb413
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
This PR allows running CAPD with a remote Docker engine by setting the CAPD_DOCKER_HOST env var.
This covers parts of #5634, although not on a per-cluster basis, just for the entire CAPD controller.
The remote engine can be used by setting the env var in either tilt-settings.yaml or as env var before running clusterctl init or in an IDE run configuration for an e2e test:
I'll follow-up with documentation once #8135 is ready
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #