Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete post pivoting changes #817

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Fix delete post pivoting changes #817

merged 1 commit into from
Mar 13, 2019

Conversation

detiber
Copy link
Member

@detiber detiber commented Mar 12, 2019

What this PR does / why we need it:
Addresses a couple of issues that have cropped up with the clusterctl delete workflow after the recent pivot changes.

  • Properly handle delete of all cluster-api objects across all namespaces when namespace is not provided on delete
  • Add a sleep to delete to allow for the cluster-api objects to be reconciled before deleting objects post-pivot.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2019
@detiber
Copy link
Member Author

detiber commented Mar 12, 2019

/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 12, 2019
@detiber detiber changed the title Fix delete post pivoting changes [WIP] Fix delete post pivoting changes Mar 12, 2019
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2019
@detiber detiber changed the title [WIP] Fix delete post pivoting changes Fix delete post pivoting changes Mar 13, 2019
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2019
@detiber
Copy link
Member Author

detiber commented Mar 13, 2019

@vincepri @chuckha this should be good to go now.

vincepri
vincepri approved these changes Mar 13, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/assign @chuckha

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2019
@chuckha
Copy link
Contributor

chuckha commented Mar 13, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2019
@chuckha
Copy link
Contributor

chuckha commented Mar 13, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit c488193 into kubernetes-sigs:master Mar 13, 2019
@vincepri vincepri added this to the v1alpha1 milestone Mar 21, 2019
@detiber detiber deleted the FixDelete branch April 2, 2019 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckha chuckha chuckha left review comments

@vincepri vincepri vincepri approved these changes

@krousey krousey Awaiting requested review from krousey

Assignees

@chuckha chuckha

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1alpha1
Development

Successfully merging this pull request may close these issues.
4 participants
@detiber @k8s-ci-robot @chuckha @vincepri