-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add breaking changes section to introduction.md #8165
📖 Add breaking changes section to introduction.md #8165
Conversation
be161fa
to
af5782b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thank you for adding this
/lgtm
LGTM label has been added. Git tree hash: 96f8a0f06d4363eb68e0dccc7fbfe2e7df3842e0
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea!
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea 👍
af5782b
to
75b3255
Compare
75b3255
to
4cf2f9b
Compare
We want a way to call out some upcoming breaking changes for new versions. This adds a note style callout in the `ClusterAPI documentation versions` section.
4cf2f9b
to
0bf4457
Compare
/lgtm |
LGTM label has been added. Git tree hash: 43cc41f3b9674087e5b4c259cbb6fd2cded511b1
|
/lgtm @joekr Just fyi, preview is also available here: https://deploy-preview-8165--kubernetes-sigs-cluster-api.netlify.app/ |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: oscr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
We want a way to call out some upcoming breaking changes for new versions. This adds a note style callout in the
ClusterAPI documentation versions
section.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Ref #8038