🌱 Bump github.com/onsi/ginkgo/v2 from 2.8.1 to 2.8.4

[dependabot]

Bumps github.com/onsi/ginkgo/v2 from 2.8.1 to 2.8.4.

Release notes

Sourced from github.com/onsi/ginkgo/v2's releases.

v2.8.3

2.8.3

Released to fix security issue in golang.org/x/net dependency

Maintenance

• Bump golang.org/x/net from 0.6.0 to 0.7.0 (#1141) [fc1a02e]
• remove tools.go hack from documentation [0718693]

v2.8.2

2.8.2

Ginkgo now includes a tools.go file in the root directory of the ginkgo package. This should allow modules that simply go get github.com/onsi/ginkgo/v2 to also pull in the CLI dependencies. This obviates the need for consumers of Ginkgo to have their own tools.go file and makes it simpler to ensure that the version of the ginkgo CLI being used matches the version of the library. You can simply run go run github.com/onsi/ginkgo/v2/ginkgo to run the version of the cli associated with your package go.mod.

Maintenance

• Bump github.com/onsi/gomega from 1.26.0 to 1.27.0 (#1139) [5767b0a]
• Fix minor typos (#1138) [e1e9723]
• Fix link in V2 Migration Guide (#1137) [a588f60]

Changelog

Sourced from github.com/onsi/ginkgo/v2's changelog.

2.8.3

Released to fix security issue in golang.org/x/net dependency

Maintenance

• Bump golang.org/x/net from 0.6.0 to 0.7.0 (#1141) [fc1a02e]
• remove tools.go hack from documentation [0718693]

2.8.2

Ginkgo now includes a tools.go file in the root directory of the ginkgo package. This should allow modules that simply go get github.com/onsi/ginkgo/v2 to also pull in the CLI dependencies. This obviates the need for consumers of Ginkgo to have their own tools.go file and makes it simpler to ensure that the version of the ginkgo CLI being used matches the version of the library. You can simply run go run github.com/onsi/ginkgo/v2/ginkgo to run the version of the cli associated with your package go.mod.

Maintenance

• Bump github.com/onsi/gomega from 1.26.0 to 1.27.0 (#1139) [5767b0a]
• Fix minor typos (#1138) [e1e9723]
• Fix link in V2 Migration Guide (#1137) [a588f60]

Commits

• 0287561 v2.8.3
• fc1a02e Bump golang.org/x/net from 0.6.0 to 0.7.0 (#1141)
• 0718693 remove tools.go hack from documentation
• cca66a8 v2.8.2
• f05681c exploring to see whether adding a tools.go to ginkgo proper will cause consum...
• 5767b0a Bump github.com/onsi/gomega from 1.26.0 to 1.27.0 (#1139)
• e1e9723 Fix minor typos (#1138)
• a588f60 Fix link in V2 Migration Guide (#1137)
• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
• @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

[k8s-ci-robot]

Hi @dependabot[bot]. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

Tried to debug this a bit but it's not trivial. Looks like go list gives conflicting results for our api packages. No idea why

[Ankitasw]

@sbueringer getting same error while bumping in CAPA as well.

[Skarlso]

It's ginkgo's new way of being imported. It messed up the tools package chain. An "easy" fix is for golangci-lint not to lint tools. So remove the tools build tag.

It would be prudent to report this to ginkgo since they broke builds with a patch version which is not cool.

[Skarlso]

Answered in the ginkgo issue. :)

[sbueringer]

Changed the PR to bump to v2.8.4 now

[sbueringer]

/lgtm

but need approve from someone else as I messed with the PR

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 1e0d0029819f4b9004545ec002a1589982932f58

[killianmuldoon]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [killianmuldoon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment