🌱 test/framework: ensure ApplyClusterTemplateAndWait always returns a cluster

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
This PR ensures ApplyClusterTemplateAndWait always returns a cluster. This is very useful if a test fails early and we need a cluster to dump and cleanup resources via dumpSpecResourcesAndCleanup.

Let's assume input.ClusterProxy.Apply(ctx, workloadClusterTemplate, input.Args...) fails because e.g. the Cluster cannot be deployed because of some issues with the ClusterClass. Then the cluster would be nil and dumpSpecResourcesAndCleanup would panic. This change ensures we always return a cluster so we can get resources from the test run, even if the cluster creation didn't actually work.

The same applies when e.g. DiscoveryAndWaitForCluster fails.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

cc @fabriziopandini @killianmuldoon

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 6d662116231b7ecbeb3467d63eeb779b503fb975

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

@sbueringer: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-e2e-informing-main	8838eca	link	false	/test pull-cluster-api-e2e-informing-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sbueringer]

/restart

known flake will be fixed elsewhere