-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 ClusterClass: run dry-run on original and modified object #8139
🐛 ClusterClass: run dry-run on original and modified object #8139
Conversation
2efb80b
to
c01c786
Compare
/test pull-cluster-api-e2e-full-main |
1 similar comment
/test pull-cluster-api-e2e-full-main |
30d7947
to
6d86938
Compare
/test pull-cluster-api-e2e-full-main |
/retest unrelated flake |
/test pull-cluster-api-e2e-main |
6d86938
to
7324939
Compare
Ran v1.2 => main and v1.3 => main (which are failing 100% in CI) each 10x on this PR (via some additional temporary test configs) and it always worked:
Removed that hack now and PR should be ready. |
/test pull-cluster-api-e2e-full-main |
/test pull-cluster-api-e2e-full-main |
ceed9e8
to
7408c81
Compare
/test pull-cluster-api-e2e-full-main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 4afd8781d8878fe76bc09237bf224027b7fd7d9a
|
/retest independent error, will be fixed on Killian's PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, kudos for the tests
internal/controllers/topology/cluster/structuredmerge/serversidepathhelper_test.go
Show resolved
Hide resolved
internal/controllers/topology/cluster/structuredmerge/serversidepathhelper_test.go
Show resolved
Hide resolved
Signed-off-by: Stefan Büringer [email protected]
7408c81
to
4d3b181
Compare
/lgtm |
LGTM label has been added. Git tree hash: ac12ead1e4bf3e57e97bc15bc2f13dace0a0c8db
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Let's keep track somehow that we need to think to a solution to avoid dryRun calls when objects are not changed |
I'll implement it (probably either today or tomorrow) |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #8101