🌱 Make Cluster webhook less strict for out of date ClusterClasses #8136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
killianmuldoon
force-pushed
the
pr-exvars-lenient-cluster-webhook
branch
from
4536ff6 to
48b899f
Compare
sbueringer
reviewed
Feb 20, 2023
sbueringer
reviewed
Feb 20, 2023
killianmuldoon
force-pushed
the
pr-exvars-lenient-cluster-webhook
branch
from
48b899f to
03f3d7c
Compare
|
/test pull-cluster-api-e2e-full-main |
killianmuldoon
force-pushed
the
pr-exvars-lenient-cluster-webhook
branch
from
03f3d7c to
0cd877b
Compare
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
killianmuldoon
commented
Feb 20, 2023
killianmuldoon
force-pushed
the
pr-exvars-lenient-cluster-webhook
branch
from
0cd877b to
a6422b5
Compare
|
/test pull-cluster-api-e2e-full-main |
|
/retest |
sbueringer
reviewed
Feb 20, 2023
killianmuldoon
force-pushed
the
pr-exvars-lenient-cluster-webhook
branch
from
a6422b5 to
db2d192
Compare
sbueringer
reviewed
Feb 20, 2023
killianmuldoon
force-pushed
the
pr-exvars-lenient-cluster-webhook
branch
from
db2d192 to
049b8fe
Compare
|
/lgtm /assign @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f1a76b8524cc682061aabcf42f4afdcd61b0729f
|
|
/test pull-cluster-api-e2e-full-main |
sbueringer
reviewed
Feb 20, 2023
killianmuldoon
force-pushed
the
pr-exvars-lenient-cluster-webhook
branch
from
049b8fe to
ee4948e
Compare
k8s-ci-robot
removed
the
lgtm
k8s-ci-robot
added
size/L
killianmuldoon
force-pushed
the
pr-exvars-lenient-cluster-webhook
branch
from
ee4948e to
8643d89
Compare
sbueringer
reviewed
Feb 21, 2023
killianmuldoon
force-pushed
the
pr-exvars-lenient-cluster-webhook
branch
from
8643d89 to
d9226f2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 69fb14e7b039d47b515e12882464e4106345d6df
|
|
/test pull-cluster-api-e2e-full-main /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
CI green /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the Cluster webhook less strict when dealing with a ClusterClass that has not been successfully reconciled. For defaulting and validation scenarios, a ClusterClass that has not been successfully reconciled is treated in the same way as a ClusterClass which does not exist.
Related to #7985