-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 docs: document new Kubernetes support policy #8134
📖 docs: document new Kubernetes support policy #8134
Conversation
cc @kubernetes-sigs/cluster-api-maintainers |
cc @killianmuldoon (you should be added to the maintainers team soon :)) |
I'll bring this PR up in the office hour on Wednesday to figure out the lazy consenus timeline. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 69630a0203da789fae80aa57a456a7b84ad3be70
|
docs/book/src/reference/versions.md
Outdated
| Kubernetes v1.24 | | | | ✓ | ✓ | ✓ | ✓ | | ||
| Kubernetes v1.25 | | | | | ✓ | ✓ | ✓ | | ||
| Kubernetes v1.26 | | | | | ✓ | ✓ | ✓ | | ||
| | v0.3 (v1alpha3) | v0.4 (v1alpha4) | v1.0 (v1beta1) | v1.1 (v1beta1) | v1.2 (v1beta1) | v1.3 (v1beta1) | v1.4 (v1beta1) | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: should we add an out of support notice below minors?
Also, at some point, we should also consider dropping columns from those tables
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think about dropping v0.3, v0.4, v1.0 columns (we even dropped the jobs now)?
(also fine for me to keep them if we want to)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added (EOL) as (out of support) requires another two lines in the table header
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 to drop the columns, if someone want to look at older version support, they can look at holder versions of the book
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, follow-up: #8168
Signed-off-by: Stefan Büringer [email protected]
bfde5b8
to
4507ff5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As per discussion in the office hour, setting lazy consensus to 1st March |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 788e979da0e5bdcf33329a35c8745ab360a2106d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Great job here, thank you!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@sbueringer what about backporting this set of changes to the current version of the book as well? |
/cherry-pick release-1.3 Why not. Looks like the v1.3 book already contains the table with v1.4 (which I didn't expect, but it's also not really a problem) |
@sbueringer: new pull request created: #8174 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Part of #8040