Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 docs: document new Kubernetes support policy #8134

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #8040

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 20, 2023
@sbueringer sbueringer mentioned this pull request Feb 20, 2023
3 tasks
@sbueringer
Copy link
Member Author

cc @kubernetes-sigs/cluster-api-maintainers
cc @kubernetes-sigs/cluster-api-release-team

@sbueringer
Copy link
Member Author

sbueringer commented Feb 20, 2023

cc @killianmuldoon (you should be added to the maintainers team soon :))

@sbueringer
Copy link
Member Author

sbueringer commented Feb 20, 2023

I'll bring this PR up in the office hour on Wednesday to figure out the lazy consenus timeline.

Copy link
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 69630a0203da789fae80aa57a456a7b84ad3be70

docs/book/src/reference/versions.md Outdated Show resolved Hide resolved
docs/book/src/reference/versions.md Outdated Show resolved Hide resolved
| Kubernetes v1.24 | | | | ✓ | ✓ | ✓ | ✓ |
| Kubernetes v1.25 | | | | | ✓ | ✓ | ✓ |
| Kubernetes v1.26 | | | | | ✓ | ✓ | ✓ |
| | v0.3 (v1alpha3) | v0.4 (v1alpha4) | v1.0 (v1beta1) | v1.1 (v1beta1) | v1.2 (v1beta1) | v1.3 (v1beta1) | v1.4 (v1beta1) |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: should we add an out of support notice below minors?
Also, at some point, we should also consider dropping columns from those tables

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about dropping v0.3, v0.4, v1.0 columns (we even dropped the jobs now)?
(also fine for me to keep them if we want to)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added (EOL) as (out of support) requires another two lines in the table header

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to drop the columns, if someone want to look at older version support, they can look at holder versions of the book

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, follow-up: #8168

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2023
@k8s-ci-robot k8s-ci-robot requested a review from elmiko February 22, 2023 11:18
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbueringer
Copy link
Member Author

As per discussion in the office hour, setting lazy consensus to 1st March

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 788e979da0e5bdcf33329a35c8745ab360a2106d

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Great job here, thank you!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit eb9cea2 into kubernetes-sigs:main Feb 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 23, 2023
@sbueringer sbueringer deleted the pr-k-support-policy branch February 24, 2023 04:29
@fabriziopandini
Copy link
Member

@sbueringer what about backporting this set of changes to the current version of the book as well?

@sbueringer
Copy link
Member Author

/cherry-pick release-1.3

Why not. Looks like the v1.3 book already contains the table with v1.4 (which I didn't expect, but it's also not really a problem)

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #8174

In response to this:

/cherry-pick release-1.3

Why not. Looks like the v1.3 book already contains the table with v1.4 (which I didn't expect, but it's also not really a problem)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants