⚠️ Add filter to associate variables with specific patches #8128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/XXL
34 tasks
killianmuldoon
commented
Feb 17, 2023
killianmuldoon
force-pushed
the
pr-exvars-per-definition-patches
branch
2 times, most recently
from
ce5ab5f to
dbb9fdf
Compare
k8s-ci-robot
added
size/L
killianmuldoon
force-pushed
the
pr-exvars-per-definition-patches
branch
5 times, most recently
from
6e2ff22 to
2da2063
Compare
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
killianmuldoon
changed the title
sbueringer
reviewed
Feb 22, 2023
internal/controllers/topology/cluster/patches/variables/variables.go
Outdated
Show resolved
Hide resolved
|
I like the general direction of this PR. I think we have to do an additional check though (#8128 (comment)), otherwise only nits |
killianmuldoon
force-pushed
the
pr-exvars-per-definition-patches
branch
2 times, most recently
from
690554e to
3b57d7f
Compare
killianmuldoon
changed the title
killianmuldoon
changed the title
sbueringer
reviewed
Feb 23, 2023
internal/controllers/topology/cluster/patches/variables/variables.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables_test.go
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
pr-exvars-per-definition-patches
branch
2 times, most recently
from
2acb3cd to
a91cbd1
Compare
killianmuldoon
force-pushed
the
pr-exvars-per-definition-patches
branch
from
a91cbd1 to
edb64fa
Compare
|
/retest |
sbueringer
reviewed
Feb 23, 2023
internal/controllers/topology/cluster/patches/variables/variables.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables_test.go
Outdated
Show resolved
Hide resolved
internal/controllers/topology/cluster/patches/variables/variables_test.go
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
pr-exvars-per-definition-patches
branch
from
edb64fa to
090c27b
Compare
|
Thank you very much! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: ade3f05801abd2e6891576ae5a98677464313b84
|
|
/test pull-cluster-api-e2e-full-main |
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
/lgtm feel free to un-hold when ready |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
e2e is green Thx everyone! /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a filter to the variable creation logic in the patch engine to associate variables with specific patches. This means that variables now have a per-patch definition i.e. inline patches can only use inline variables, while external patches only use variables discovered through a discoverVariablesExtension defined as part of that patch.
Part of #7985