-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration test to verify controller pods status #811
Conversation
Checking on the output of the integration tests, I noticed that there is an Error displayed, but the test still shows as passing: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/811/pull-cluster-api-integration/102 |
The resources are verified by kubectl during apply, but controller pods are unverified. also invoke the new tests been adding under ./test/integration/ with this, we should expect the integration ci job automatically pick up new test under ./test/integration
/milestone v1alpha1 |
@detiber the error happened when run |
/lgtm |
/assign @vincepri |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super minor comment.
/approve
#TODO: verify cluster-api CRD on bootstrap cluster | ||
wait_pod_running() { | ||
retry=30 | ||
INTERVAL=6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason these vars are in different cases?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, no strong reason, thanks
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: figo, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The resources are verified by kubectl during apply,
but controller pods are unverified.
also invoke the new tests been adding under ./test/integration/
with this, we should expect the integration ci job automatically
pick up new test under ./test/integration
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note:
cc @vincepri @detiber @pablochacin