Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration test to verify controller pods status #811

Merged
merged 1 commit into from
Mar 8, 2019

Conversation

figo
Copy link
Contributor

@figo figo commented Mar 8, 2019

The resources are verified by kubectl during apply,
but controller pods are unverified.

also invoke the new tests been adding under ./test/integration/
with this, we should expect the integration ci job automatically
pick up new test under ./test/integration

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


cc @vincepri @detiber @pablochacin

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 8, 2019
@detiber
Copy link
Member

detiber commented Mar 8, 2019

Checking on the output of the integration tests, I noticed that there is an Error displayed, but the test still shows as passing: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/811/pull-cluster-api-integration/102

The resources are verified by kubectl during apply,
but controller pods are unverified.

also invoke the new tests been adding under ./test/integration/
with this, we should expect the integration ci job automatically
pick up new test under ./test/integration
@figo figo force-pushed the integration-patch branch from 480e4c9 to 091079c Compare March 8, 2019 20:43
@detiber
Copy link
Member

detiber commented Mar 8, 2019

/milestone v1alpha1

@k8s-ci-robot k8s-ci-robot added this to the v1alpha1 milestone Mar 8, 2019
@figo
Copy link
Contributor Author

figo commented Mar 8, 2019

Checking on the output of the integration tests, I noticed that there is an Error displayed, but the test still shows as passing: https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api/811/pull-cluster-api-integration/102

@detiber the error happened when run bazel run //:gazelle, re-run succeed, problem is Gazelle return success when encountered issue.
i did some research, looks like a known design of Gazelle, not sure how much we can do about it at his moment, https://groups.google.com/forum/#!topic/bazel-go-discuss/lBMp9Jg7uNE

@detiber
Copy link
Member

detiber commented Mar 8, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2019
@detiber
Copy link
Member

detiber commented Mar 8, 2019

/assign @vincepri

Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super minor comment.

/approve

#TODO: verify cluster-api CRD on bootstrap cluster
wait_pod_running() {
retry=30
INTERVAL=6
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason these vars are in different cases?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, no strong reason, thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: figo, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2019
@k8s-ci-robot k8s-ci-robot merged commit a2f5862 into kubernetes-sigs:master Mar 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants