Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 CAPD: reduce noisy error logs during machine reconciliation #8090

Merged
merged 1 commit into from
Feb 12, 2023
+11 −0
Merged

🌱 CAPD: reduce noisy error logs during machine reconciliation #8090

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/infrastructure/docker/internal/controllers/dockermachine_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,17 @@ func (r *DockerMachineReconciler) reconcileNormal(ctx context.Context, cluster *
return ctrl.Result{RequeueAfter: 5 * time.Second}, nil
}

// If the Cluster is using a control plane and the control plane is not yet initialized, there is no API server
// to contact to get the ProviderID for the Node hosted on this machine, so return early.
// NOTE: We are using RequeueAfter with a short interval in order to make test execution time more stable.
// NOTE: If the Cluster doesn't use a control plane, the ControlPlaneInitialized condition is only
// set to true after a control plane machine has a node ref. If we would requeue here in this case, the
// Machine will never get a node ref as ProviderID is required to set the node ref, so we would get a deadlock.
if cluster.Spec.ControlPlaneRef != nil &&
!conditions.IsTrue(cluster, clusterv1.ControlPlaneInitializedCondition) {
return ctrl.Result{RequeueAfter: 15 * time.Second}, nil
}

// Usually a cloud provider will do this, but there is no docker-cloud provider.
// Requeue if there is an error, as this is likely momentary load balancer
// state changes during control plane provisioning.
Expand Down