Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 ClusterClass: also consider MD unavailableReplicas for rollout #8063

Merged
merged 1 commit into from
Feb 12, 2023
Merged

🌱 ClusterClass: also consider MD unavailableReplicas for rollout #8063

merged 1 commit into from
Feb 12, 2023

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 6, 2023
@sbueringer
Copy link
Member Author

@fabriziopandini @ykakarap WDYT would it make sense to also check unavailableReplicas for MD's like we're doing for control planes?

killianmuldoon
killianmuldoon approved these changes Feb 6, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 617f360253b8a30168570f5205798399aae892cf

@sbueringer
Copy link
Member Author

/hold
have to take a look if we should extend unit tests, once I know if we want to do this change

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2023
@fabriziopandini
Copy link
Member

/lgtm
/approve

@sbueringer I think this is a nice improvement, let's get it merged if test grid is green

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 9, 2023
@sbueringer
Copy link
Member Author

Sounds good

/test pull-cluster-api-e2e-full-main

I spent a few minutes later checking if we want to extend our unit tests a bit

@sbueringer sbueringer force-pushed the pr-cc-md-unavailable-replicas branch from d87da9c to 9d20ebf Compare February 9, 2023 15:17
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 9, 2023
sbueringer
sbueringer commented Feb 9, 2023
View reviewed changes
internal/controllers/topology/cluster/desired_state_test.go
@@ -1769,6 +1771,7 @@ func TestComputeMachineDeploymentVersion(t *testing.T) {
// - md.spec.replicas == md.status.replicas
// - md.spec.replicas == md.status.updatedReplicas
// - md.spec.replicas == md.status.readyReplicas
// - md.status.unavailableReplicas == 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of comments like this.

Basically you can never trust them because it's close to impossible to keep them up-to-date over time

@sbueringer
Copy link
Member Author

@fabriziopandini Extended tests a bit. Should be ready now

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2023
@fabriziopandini
Copy link
Member

Thanks for the extensive work on testing, really appreciated!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 47d5f0b088ee84dbbb0c0b21749bf3d8bbb49fad

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 4fdf6cb into kubernetes-sigs:main Feb 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 12, 2023
@sbueringer sbueringer deleted the pr-cc-md-unavailable-replicas branch February 13, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardcase richardcase Awaiting requested review from richardcase

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@sbueringer @k8s-ci-robot @fabriziopandini @killianmuldoon