Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rev the version of golangci-lint used #806

Merged
merged 1 commit into from
Mar 6, 2019
Merged

Rev the version of golangci-lint used #806

merged 1 commit into from
Mar 6, 2019

Conversation

detiber
Copy link
Member

@detiber detiber commented Mar 6, 2019

What this PR does / why we need it:
Updates the version of golangci-lint we are using

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 6, 2019
@k8s-ci-robot k8s-ci-robot requested review from krousey and vincepri March 6, 2019 15:50
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 6, 2019
@detiber
Copy link
Member Author

detiber commented Mar 6, 2019

/assign @vincepri
/assign @randomvariable

@detiber detiber mentioned this pull request Mar 6, 2019
Merged
@detiber
Copy link
Member Author

detiber commented Mar 6, 2019

/test pull-cluster-api-make
/test pull-cluster-api-test

@detiber
Copy link
Member Author

detiber commented Mar 6, 2019

/close

@k8s-ci-robot
Copy link
Contributor

@detiber: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@detiber detiber reopened this Mar 6, 2019
@detiber
Copy link
Member Author

detiber commented Mar 6, 2019

pull-cluster-api-test failure is related to the issue fixed in #805

@detiber
Copy link
Member Author

detiber commented Mar 6, 2019

/test pull-cluster-api-test

@vincepri
Copy link
Member

vincepri commented Mar 6, 2019

@detiber The other PR has been merged, does this need a rebase?

@detiber
Copy link
Member Author

detiber commented Mar 6, 2019

@vincepri doesn't look like a rebase is needed, should be good to go now.

vincepri
vincepri approved these changes Mar 6, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 6, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: detiber, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2019
@figo
Copy link
Contributor

figo commented Mar 6, 2019

/test pull-cluster-api-test

@figo
Copy link
Contributor

figo commented Mar 6, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot merged commit a7f1907 into kubernetes-sigs:master Mar 6, 2019
@vincepri vincepri added this to the v1alpha1 milestone Mar 21, 2019
@detiber detiber deleted the revgolangci-lint branch April 2, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@krousey krousey Awaiting requested review from krousey

Assignees

@figo figo

@randomvariable randomvariable

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1alpha1
Development

Successfully merging this pull request may close these issues.
5 participants
@detiber @k8s-ci-robot @vincepri @figo @randomvariable