Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Update golangci-lint to v1.51.0 #8046

Merged
merged 1 commit into from
Feb 2, 2023
Merged

🌱 Update golangci-lint to v1.51.0 #8046

merged 1 commit into from
Feb 2, 2023

Conversation

killianmuldoon
Copy link
Contributor

@killianmuldoon killianmuldoon commented Feb 2, 2023 •
edited
Loading

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 2, 2023
killianmuldoon
killianmuldoon commented Feb 2, 2023
View reviewed changes
util/container/image.go Outdated
@@ -17,8 +17,7 @@ limitations under the License.
// Package container implements container utility functionality.
package container

import (
// Import the crypto sha256 algorithm for the docker image parser to work
import ( // Import the crypto sha256 algorithm for the docker image parser to work
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the gci linter has some new opinions about comment placement - it looks worse to me, but I'm fine with merging this as it won't impact in many places.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I prefer the new variant. I think it's the mainstream variant (IIRC)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah - the current version is nice. The outdated version above was the result from make lint-fix and it is ... not nice

@killianmuldoon
Copy link
Contributor Author

/retest

@killianmuldoon killianmuldoon force-pushed the pr-update-golangci-lint branch from c997214 to 6e25b5c Compare February 2, 2023 11:25
@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d041166102077b439c5b43451b392b3523b2b5e7

@oscr
Copy link
Contributor

oscr commented Feb 2, 2023

/lgtm

@sbueringer
Copy link
Member

/approve

@oscr It could be interesting to test the new ginkgolinter in a follow-up (I didn't take a closer look what kind of changes it would enforce, so we definitely would have to take a look first before we decide)

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit d4eee3f into kubernetes-sigs:main Feb 2, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 2, 2023
@killianmuldoon
Copy link
Contributor Author

interesting to test the new ginkgolinter in a follow-up (I didn't take a closer look what kind of changes it would enforce, so we definitely would have to take a look first before we decide)

I couldn't get this to run quickly so I decided to do a quick update - it was crashing for me 🤔

@oscr
Copy link
Contributor

oscr commented Feb 2, 2023

I couldn't get this to run quickly so I decided to do a quick update - it was crashing for me thinking

I was actually experimenting with a similar pr as this one, but ginkgolinter was also crashing for me 😁

@sbueringer
Copy link
Member

Should we track it in an issue for now and then re-evaluate once those issues are resolved? (we should probably report them when we have time)

@oscr oscr mentioned this pull request Feb 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@enxebre enxebre Awaiting requested review from enxebre

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@oscr oscr

@stmcginnis stmcginnis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@killianmuldoon @stmcginnis @k8s-ci-robot @oscr @sbueringer