Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Move machine controller tests to envtest, drop disableNodeLabelSync #8044

Merged
merged 1 commit into from
Feb 21, 2023
Merged

🌱 Move machine controller tests to envtest, drop disableNodeLabelSync #8044

merged 1 commit into from
Feb 21, 2023

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #7964

@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 1, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 1, 2023
@sbueringer sbueringer force-pushed the pr-machine-controller-envtest branch from 4f50a44 to 5a27f75 Compare February 2, 2023 20:28
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 2, 2023
@sbueringer sbueringer changed the title [WIP] [DNR] 🌱 Move machine controller tests to envtest 🌱 Move machine controller tests to envtest, drop disableNodeLabelSync Feb 2, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 2, 2023
@sbueringer
Copy link
Member Author

/assign @fabriziopandini @ykakarap

@sbueringer sbueringer force-pushed the pr-machine-controller-envtest branch from 5a27f75 to fdd7492 Compare February 2, 2023 20:30
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 2, 2023
@sbueringer sbueringer force-pushed the pr-machine-controller-envtest branch from fdd7492 to e8aa4b3 Compare February 3, 2023 09:59
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 3, 2023
@sbueringer sbueringer force-pushed the pr-machine-controller-envtest branch from e8aa4b3 to 6a9f7a4 Compare February 3, 2023 10:04
@sbueringer
Copy link
Member Author

Should be ready now

@sbueringer
Migrate machine tests to envtest
58c5874 
Signed-off-by: Stefan Büringer [email protected]
@sbueringer sbueringer force-pushed the pr-machine-controller-envtest branch from 6a9f7a4 to 58c5874 Compare February 13, 2023 10:49
@sbueringer
Copy link
Member Author

/assign @jackfrancis @richardcase

fabriziopandini
fabriziopandini reviewed Feb 19, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 19, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d5fe5407f4811514fa2c932bab78f073e08b309e

@sbueringer
Copy link
Member Author

/lgtm
/approve

Given lgtm above. Let's start merging to reduce the amount of open PRs.

@k8s-ci-robot
Copy link
Contributor

@sbueringer: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Given lgtm above. Let's start merging to reduce the amount of open PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit b1c0044 into kubernetes-sigs:main Feb 21, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 21, 2023
@sbueringer sbueringer deleted the pr-machine-controller-envtest branch February 21, 2023 08:09
@killianmuldoon killianmuldoon mentioned this pull request Mar 24, 2023
Merged
@killianmuldoon killianmuldoon mentioned this pull request Apr 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@richardcase richardcase

@jackfrancis jackfrancis

@fabriziopandini fabriziopandini

@ykakarap ykakarap

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

switch machine controller tests that use SSA to envtest and drop disableNodeLabelSync
6 participants
@sbueringer @k8s-ci-robot @fabriziopandini @richardcase @jackfrancis @ykakarap