Update Bazel rules_go to 0.18 #804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
detiber
reviewed
Mar 5, 2019
| @@ -4,7 +4,7 @@ load("@bazel_tools//tools/build_defs/repo:git.bzl", "git_repository") | |||
| http_archive( | |||
| name = "io_bazel_rules_go", | |||
| sha256 = "6776d68ebb897625dead17ae510eac3d5f6342367327875210df44dbe2aeeb19", | |||
| urls = ["https://github.com/bazelbuild/rules_go/releases/download/0.17.1/rules_go-0.17.1.tar.gz"], | |||
| urls = ["https://github.com/bazelbuild/rules_go/releases/download/0.18.0/rules_go-0.18.0.tar.gz"], | |||
k8s-ci-robot
added
the
lgtm
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
update-bazel-rulesgo
branch
from
c3d8df9 to
d769504
Compare
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
ingvagabund
added a commit
to gofed/cluster-api
that referenced
this pull request
Mar 25, 2019
Otherwise, bazel starts complaining about and fails eventually:
ERROR: Skipping '//:gazelle': error loading package '': in /go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_gazelle/def.bzl: Encountered error while reading extension file 'lib/shell.bzl': no such package '@bazel_skylib//lib': Traceback (most recent call last):
File "/go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_tools/tools/build_defs/repo/git.bzl", line 163
_clone_or_update(ctx)
File "/go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_tools/tools/build_defs/repo/git.bzl", line 73, in _clone_or_update
fail(("error cloning %s:\n%s" % (ctx....)))
error cloning bazel_skylib:
Undoing upstream kubernetes-sigs#804 and kubernetes-sigs#801.
openshift-merge-robot
pushed a commit
to openshift/cluster-api
that referenced
this pull request
Mar 26, 2019
Otherwise, bazel starts complaining about and fails eventually:
ERROR: Skipping '//:gazelle': error loading package '': in /go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_gazelle/def.bzl: Encountered error while reading extension file 'lib/shell.bzl': no such package '@bazel_skylib//lib': Traceback (most recent call last):
File "/go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_tools/tools/build_defs/repo/git.bzl", line 163
_clone_or_update(ctx)
File "/go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_tools/tools/build_defs/repo/git.bzl", line 73, in _clone_or_update
fail(("error cloning %s:\n%s" % (ctx....)))
error cloning bazel_skylib:
Undoing upstream kubernetes-sigs#804 and kubernetes-sigs#801.
ingvagabund
added a commit
to gofed/cluster-api
that referenced
this pull request
May 21, 2019
Otherwise, bazel starts complaining about and fails eventually:
ERROR: Skipping '//:gazelle': error loading package '': in /go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_gazelle/def.bzl: Encountered error while reading extension file 'lib/shell.bzl': no such package '@bazel_skylib//lib': Traceback (most recent call last):
File "/go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_tools/tools/build_defs/repo/git.bzl", line 163
_clone_or_update(ctx)
File "/go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_tools/tools/build_defs/repo/git.bzl", line 73, in _clone_or_update
fail(("error cloning %s:\n%s" % (ctx....)))
error cloning bazel_skylib:
Undoing upstream kubernetes-sigs#804 and kubernetes-sigs#801.
ingvagabund
added a commit
to ingvagabund/cluster-api
that referenced
this pull request
Jun 3, 2019
Otherwise, bazel starts complaining about and fails eventually:
ERROR: Skipping '//:gazelle': error loading package '': in /go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_gazelle/def.bzl: Encountered error while reading extension file 'lib/shell.bzl': no such package '@bazel_skylib//lib': Traceback (most recent call last):
File "/go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_tools/tools/build_defs/repo/git.bzl", line 163
_clone_or_update(ctx)
File "/go/src/github.com/openshift/cluster-api/_output/.cache/_bazel_root/329e6b0155c0ea7976c3e2bc09b71040/external/bazel_tools/tools/build_defs/repo/git.bzl", line 73, in _clone_or_update
fail(("error cloning %s:\n%s" % (ctx....)))
error cloning bazel_skylib:
Undoing upstream kubernetes-sigs#804 and kubernetes-sigs#801.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
Updates the bazel rules_go archive to latest version.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: