🐛 KCP: Allow unsetting fields if their child fields are mutable

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
This PR makes parent fields mutable if there fields already are.

An example is that it was possible to modify rolloutBefore.certificatesExpiryDays but not to unset rolloutBefore.

I did this for all fields as I think we want to allow to unset all of them. In some cases it's theoretically not necessary because when the field is unset either it's marshalled as an empty object or defaulting is run. But I think it's easier to make them all mutable instead of documenting the various cases.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

/cherry-pick release-1.3

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[randomvariable]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d0dc9cf13fd16d6744a5460eb8d371e3dc8afe8a

[killianmuldoon]

/lgtm

[ykakarap]

/lgtm

Do we also need to cherry-pick this back to release-1.2. release-1.2 does not have the rolloutBefore field but does it still apply for the other fields?

[sbueringer]

Good idea. Let's do it. Don't want to deal with this problem again

[sbueringer]

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

(just to get notified)

[killianmuldoon]

/rename bug KCP: Allow unsetting fields if their child fields are mutable

[killianmuldoon]

/retitle 🐛 KCP: Allow unsetting fields if their child fields are mutable

[fabriziopandini]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #8081

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@sbueringer: #8037 failed to apply on top of branch "release-1.2":

Applying: KCP: Allow unsetting fields if there childs are mutable
Using index info to reconstruct a base tree...
M	controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_webhook.go
M	controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_webhook_test.go
Falling back to patching base and 3-way merge...
Auto-merging controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_webhook_test.go
CONFLICT (content): Merge conflict in controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_webhook_test.go
Auto-merging controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_webhook.go
CONFLICT (content): Merge conflict in controlplane/kubeadm/api/v1beta1/kubeadm_control_plane_webhook.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 KCP: Allow unsetting fields if there childs are mutable
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.