Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Add DefinitionFrom field to ClusterVariable #8031

Conversation

killianmuldoon
Copy link
Contributor

Add a DefinitionFrom field to the ClusterVariable type for use with conflicting VariableDefinitions.

Part of #7985

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 31, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 31, 2023
// patches. It must comply to the corresponding
// ClusterClassVariable defined in the ClusterClass.
// ClusterVariable can be used to customize the Cluster through patches. Each ClusterVariable is associated with a
// Variable definition in the ClusterClass `status` variables.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much documentation is useful here in terms of the usage of this field. I think it's complex enough that the godoc isn't the right place to describe e.g. that variables can't be used across patches.

@killianmuldoon killianmuldoon mentioned this pull request Jan 31, 2023
34 tasks
@killianmuldoon killianmuldoon changed the title [WIP] 🌱 Add DefinitionFrom field to ClusterVariable 🌱 Add DefinitionFrom field to ClusterVariable Feb 8, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2023
@killianmuldoon
Copy link
Contributor Author

/retest

@sbueringer
Copy link
Member

@killianmuldoon
stdout:

The Cluster "k8s-upgrade-with-runtimesdk-ggtj3h" is invalid: 
* spec.topology.variables[0].definitionFrom: Invalid value: "null": spec.topology.variables[0].definitionFrom in body must be of type string: "null"
* spec.topology.variables[1].definitionFrom: Invalid value: "null": spec.topology.variables[1].definitionFrom in body must be of type string: "null"
* spec.topology.variables[2].definitionFrom: Invalid value: "null": spec.topology.variables[2].definitionFrom in body must be of type string: "null"

@killianmuldoon killianmuldoon force-pushed the pr-exvars-cluster-variable-definition branch from 44060f3 to ddf405c Compare February 8, 2023 12:21
@sbueringer
Copy link
Member

/lgtm

/assign @fabriziopandini

godoc sounds fine to me. I think we could iterate later on if we see in subsequent implementations that we want to add more

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2297b2fe5225aa37b20ccbc4f5531d8fc430b758

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 12, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9ae5fc5 into kubernetes-sigs:main Feb 12, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants