-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add DefinitionFrom field to ClusterVariable #8031
🌱 Add DefinitionFrom field to ClusterVariable #8031
Conversation
// patches. It must comply to the corresponding | ||
// ClusterClassVariable defined in the ClusterClass. | ||
// ClusterVariable can be used to customize the Cluster through patches. Each ClusterVariable is associated with a | ||
// Variable definition in the ClusterClass `status` variables. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how much documentation is useful here in terms of the usage of this field. I think it's complex enough that the godoc isn't the right place to describe e.g. that variables can't be used across patches.
/retest |
@killianmuldoon
|
44060f3
to
ddf405c
Compare
/lgtm /assign @fabriziopandini godoc sounds fine to me. I think we could iterate later on if we see in subsequent implementations that we want to add more |
LGTM label has been added. Git tree hash: 2297b2fe5225aa37b20ccbc4f5531d8fc430b758
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add a DefinitionFrom field to the ClusterVariable type for use with conflicting VariableDefinitions.
Part of #7985