🌱 make ensure scripts fail if GOPATH/bin not in PATH

[tuminoid]

ensure-kind.sh and ensure-kubectl.sh install binaries into $GOPATH/bin, but nowhere it checks that $GOPATH/bin is in user's PATH. In this case, the newly installed binaries won't be found later on.

[k8s-ci-robot]

Hi @tuminoid. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/ok-to-test

[sbueringer]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c42d2beef84fd72ae4b933f4a4f4141aa61372d6

[tuminoid]

/assign @CecileRobertMichon

[sbueringer]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: be59b7912822e64ebb578166035ade2726127c80

[tuminoid]

Moved the logic to ensure-go.sh, which is called before other ensure scripts.

[tuminoid]

Move logic to function in utils.sh, called by ensure-*.sh if they install binary to GOPATH_BIN.

[sbueringer]

Thank you!

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: bd61588f209f3b8253063e37105288e3a8a210e6

[CecileRobertMichon]

thanks!

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CecileRobertMichon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [CecileRobertMichon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

@tuminoid @CecileRobertMichon @furkatgofurov7
Just fyi. This broke the test periodics because we didn't have the same config there as in our presubmits.

Here is the fix: kubernetes/test-infra#28602

[CecileRobertMichon]

Interesting, not sure I understand how the preriodics were working before that but in any case, thanks for fixing it!

[sbueringer]

I guess the images had the binaries built in (and not sure what the unit tests actually need) and we weren't depending on runner.sh in those jobs (as we are not using kind/ dind there)