Support MachineDeployment adoption of MachineSets #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
vincepri
commented
Mar 1, 2019
vincepri
force-pushed
the
deployment-adopt-set
branch
from
3b1aa7e to
96b8fbb
Compare
detiber
reviewed
Mar 1, 2019
vincepri
force-pushed
the
deployment-adopt-set
branch
from
96b8fbb to
5274bb8
Compare
|
Overall the changes look good to me. It might be good to add some tests to validate that we only adopt MachineSets under the appropriate conditions. This will also require a new cluster-api release and an updated image to be pushed before this could be consumed by downstream providers (such as for the pivot workflow). |
|
Will do later this afternoon, thanks! |
Signed-off-by: Vince Prignano <[email protected]>
vincepri
force-pushed
the
deployment-adopt-set
branch
from
ae7a8ab to
28170b0
Compare
k8s-ci-robot
added
size/L
|
@detiber ptal |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
This PR adds support in MachineDeployments to adopt existing MachineSets without a controller reference.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #746
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: