Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add observedGeneration to ClusterClass status #7987

Merged
merged 1 commit into from
Jan 27, 2023
Merged

🌱 Add observedGeneration to ClusterClass status #7987

merged 1 commit into from
Jan 27, 2023

Conversation

killianmuldoon
Copy link
Contributor

Add an observedGeneration field to the ClusterClass status so other controllers and agents can ensure they're working with data that has been successfully reconciled by the CC controller.

Part of #7985

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 24, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 24, 2023
@killianmuldoon killianmuldoon mentioned this pull request Jan 24, 2023
Closed
34 tasks
killianmuldoon
killianmuldoon commented Jan 24, 2023
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added the area/runtime-sdk Issues or PRs related to Runtime SDK label Jan 24, 2023
@fabriziopandini
Copy link
Member

sgtm

@killianmuldoon killianmuldoon changed the title 🌱 [WIP] Add observedGeneration to ClusterClass status 🌱 Add observedGeneration to ClusterClass status Jan 27, 2023
@killianmuldoon
Copy link
Contributor Author

/retest

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5dacfcb9b9b6b3846bff821fd826785d603d3d1c

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 358a064 into kubernetes-sigs:main Jan 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 27, 2023
@killianmuldoon killianmuldoon mentioned this pull request Jan 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@killianmuldoon @fabriziopandini @sbueringer @k8s-ci-robot