📖 Fix Runtime SDK implement extension sample to reflect updated k8s.io/component-base changes #7912
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/S
…component-base changes
chrischdi
force-pushed
the
pr-book-fix-runtimesdk-example
branch
from
34c8755 to
df53223
Compare
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 6136611dacaa0058da3a782c5fd1878e1b56a19b
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Should this get cherry-picked to release-1.3 to be in the current published docs too? It's broken at the v1.3 currently 🤔 Maybe @sbueringer ? |
|
Yup, just forgot. We can/should usually always cherry-pick book changes /cherry-pick release-1.3 |
|
@sbueringer: new pull request created: #7939 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Fixes the sample to comply with the latest cluster-api dependencies.
Cherry-picks fixes of #7211 to the sample.
The dependency to cluster-api resolves to the transitive version of
k8s.io/component-base(maybe also via controller-runtime) which is not compatible anymore to the documented sample sincev0.25.0.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #