-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 CAPD: only ignore necessary kubeadm preflight errors #7911
🌱 CAPD: only ignore necessary kubeadm preflight errors #7911
Conversation
Just opened the PR already so I don't forget it. Before we merge this PR we have to adress an issue first (~ KCP sometimes patches status into an incosistent state) /hold |
Signed-off-by: Stefan Büringer [email protected]
05856c5
to
711ef87
Compare
/test ? |
@sbueringer: The following commands are available to trigger required jobs:
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test pull-cluster-api-e2e-full-main |
/assign @killianmuldoon /hold |
/lgtm |
LGTM label has been added. Git tree hash: 1d835fd7be6befa984a08f6c732ce6ab297e1a76
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
/area provider/infrastructure-docker |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
With this PR CAPD only ignores SystemVerification and Swap preflight errors. The goal is to detect other preflight errors which affect other infra providers (e.g. ImagePull). This should bring the test results of CAPD a bit closer to the ones of other infra providers.
Previously we couldn't merge this PR as we had some issues that the ImagePull preflight check for
kubeadm join
failed in upgrade tests. The root cause was that kubeadm was trying to pull images from the wrong registry. This should now not happen anymore as all our e2e tests (including the upgrade tests) are using Kubernetes versions which have theregistry.k8s.io
default registry.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #