Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added bootstrap-only components to clusterctl as an option #790

Merged
merged 1 commit into from
Mar 1, 2019
Merged

Added bootstrap-only components to clusterctl as an option #790

merged 1 commit into from
Mar 1, 2019

Conversation

sflxn
Copy link

@sflxn sflxn commented Feb 27, 2019

Allows clusterctl to apply boostrap cluster only components that will not
be applied to the target cluster.

Resolves #556

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 27, 2019
@sflxn sflxn force-pushed the bootstrap-components branch from 54b52aa to 1ef8b14 Compare February 27, 2019 23:34
vincepri
vincepri reviewed Feb 28, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens for objects referencing the bootstrap-only components? Will those references be ignored? I think the volume secrets for example breaks when it cannot find the proper reference.

@detiber
Copy link
Member

detiber commented Feb 28, 2019

What happens for objects referencing the bootstrap-only components? Will those references be ignored? I think the volume secrets for example breaks when it cannot find the proper reference.

As long as the references are from resources in providerComponents to bootstrapOnlyComponents, then this ordering should be fine.

That said, for the AWS provider, we'll need to modify the way we are generating things, since we are relying on kustomize to generate the secrets and set the references for us.

@sflxn sflxn force-pushed the bootstrap-components branch from 1ef8b14 to e028310 Compare February 28, 2019 21:09
Added bootstrap-only components to clusterctl as an option
1729b6a 
Allows clusterctl to apply boostrap cluster only components that will not
be applied to the target cluster.

Resolves kubernetes-sigs#556
@sflxn sflxn force-pushed the bootstrap-components branch from e028310 to 1729b6a Compare February 28, 2019 21:35
@detiber
Copy link
Member

detiber commented Mar 1, 2019

/lgtm
/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 1, 2019
vincepri
vincepri approved these changes Mar 1, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sflxn, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 545c1dc into kubernetes-sigs:master Mar 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@detiber detiber detiber left review comments

@vincepri vincepri vincepri approved these changes

@justinsb justinsb Awaiting requested review from justinsb

Assignees

@detiber detiber

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sflxn @detiber @k8s-ci-robot @vincepri