Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 drop the draft release notes step from github workflow #7893

Merged

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

Since the release team is taking care of generating the release notes as needed, dropping the step from the github workflow.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 10, 2023
@ykakarap
Copy link
Contributor Author

cc @kubernetes-sigs/cluster-api-release-team

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d91553855915d234f301b1c47a972015c9b22e79

@joekr
Copy link
Member

joekr commented Jan 10, 2023

/lgtm

@hackeramitkumar
Copy link
Member

+1
/lgtm

@nawazkh
Copy link
Member

nawazkh commented Jan 10, 2023

/lgtm+

@ykakarap ykakarap force-pushed the drop-release-notes-github-action branch from b3a7cf6 to ff647d2 Compare January 18, 2023 00:13
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@sbueringer
Copy link
Member

sbueringer commented Jan 18, 2023

/lgtm
/approve

I guess this PR is enough to change the workflow for all branches

Let's test it with the upcoming patch releases

(we can use this PR to figure out if that's how it works)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 4f1aad33bc3491a7f45762efbe29b96d13a159b3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit ae61579 into kubernetes-sigs:main Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 18, 2023
@ykakarap
Copy link
Contributor Author

I guess this PR is enough to change the workflow for all branches

I believe so. Since the workflow is triggered with a tag push and a tag push is not any branch specific, as far as git is considered, I believe the default branch will be used for the workflow.

We will know for sure during the next patch releases 😅

@sbueringer
Copy link
Member

Looks like it didn't work for v1.3.3

Let's backport

@sbueringer
Copy link
Member

/cherry-pick release-1.3

@sbueringer
Copy link
Member

/cherry-pick release-1.2

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #8032

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #8033

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants