-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 drop the draft release notes step from github workflow #7893
🌱 drop the draft release notes step from github workflow #7893
Conversation
cc @kubernetes-sigs/cluster-api-release-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: d91553855915d234f301b1c47a972015c9b22e79
|
/lgtm |
+1 |
/lgtm+ |
b3a7cf6
to
ff647d2
Compare
/lgtm I guess this PR is enough to change the workflow for all branches Let's test it with the upcoming patch releases (we can use this PR to figure out if that's how it works) |
LGTM label has been added. Git tree hash: 4f1aad33bc3491a7f45762efbe29b96d13a159b3
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I believe so. Since the workflow is triggered with a tag push and a tag push is not any branch specific, as far as git is considered, I believe the default branch will be used for the workflow. We will know for sure during the next patch releases 😅 |
Looks like it didn't work for v1.3.3 Let's backport |
/cherry-pick release-1.3 |
/cherry-pick release-1.2 |
@sbueringer: new pull request created: #8032 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sbueringer: new pull request created: #8033 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Since the release team is taking care of generating the release notes as needed, dropping the step from the github workflow.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #