Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Amend KCP proposal with remediation while provisioning the CP #7855

Merged

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
This PR proposes an amendment to KCP remediation so it will be possible to remediate failure happening while provisioning the CP (both first CP and CP machines while current replica < desired replica);

It also introduces opt-in control of remediation retry behavior.

Which issue(s) this PR fixes:
Rif #7496

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 5, 2023
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits, otherwise looks good!

docs/proposals/20191017-kubeadm-based-control-plane.md Outdated Show resolved Hide resolved
docs/proposals/20191017-kubeadm-based-control-plane.md Outdated Show resolved Hide resolved
docs/proposals/20191017-kubeadm-based-control-plane.md Outdated Show resolved Hide resolved
docs/proposals/20191017-kubeadm-based-control-plane.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

Thx!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 9, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0e6c9a507def215537b3239e3e82a3c70d727137

Copy link
Contributor

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks for this!

@k8s-ci-robot
Copy link
Contributor

@g-gaston: changing LGTM is restricted to collaborators

In response to this:

/lgtm
Thanks for this!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini force-pushed the improve-kcp-remediation branch from 8f52b5f to ce3e77f Compare January 13, 2023 12:09
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2023
@fabriziopandini
Copy link
Member Author

Addressed last nit, squashed commits

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3441596600cbabcacaa16d6255da4e8ddbe2ec0b

@fgutmann
Copy link
Contributor

fgutmann commented Jan 14, 2023

/lgtm
Thank you Fabrizio!

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8a30fc1 into kubernetes-sigs:main Jan 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 27, 2023
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to click a "Submit" button 🤦🏼‍♂️

- The cluster MUST have no machines with a deletion timestamp. This rule prevents KCP taking actions while the cluster is in a transitional state.
- Remediation MUST preserve etcd quorum. This rule ensures that we will not remove a member that would result in etcd
losing a majority of members and thus become unable to field new requests.
losing a majority of members and thus become unable to field new requests (note: this rule applies only to CP with at least replicas)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
losing a majority of members and thus become unable to field new requests (note: this rule applies only to CP with at least replicas)
losing a majority of members and thus become unable to field new requests (note: this rule applies only to CP with at least 3 replicas)

?

Copy link
Member Author

@fabriziopandini fabriziopandini Jan 30, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up, opened #8018

@fabriziopandini fabriziopandini deleted the improve-kcp-remediation branch January 30, 2023 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants