-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Amend KCP proposal with remediation while provisioning the CP #7855
📖 Amend KCP proposal with remediation while provisioning the CP #7855
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits, otherwise looks good!
Thx! /lgtm |
LGTM label has been added. Git tree hash: 0e6c9a507def215537b3239e3e82a3c70d727137
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Thanks for this!
@g-gaston: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
8f52b5f
to
ce3e77f
Compare
Addressed last nit, squashed commits |
/lgtm |
LGTM label has been added. Git tree hash: 3441596600cbabcacaa16d6255da4e8ddbe2ec0b
|
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to click a "Submit" button 🤦🏼♂️
- The cluster MUST have no machines with a deletion timestamp. This rule prevents KCP taking actions while the cluster is in a transitional state. | ||
- Remediation MUST preserve etcd quorum. This rule ensures that we will not remove a member that would result in etcd | ||
losing a majority of members and thus become unable to field new requests. | ||
losing a majority of members and thus become unable to field new requests (note: this rule applies only to CP with at least replicas) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
losing a majority of members and thus become unable to field new requests (note: this rule applies only to CP with at least replicas) | |
losing a majority of members and thus become unable to field new requests (note: this rule applies only to CP with at least 3 replicas) |
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for following up, opened #8018
What this PR does / why we need it:
This PR proposes an amendment to KCP remediation so it will be possible to remediate failure happening while provisioning the CP (both first CP and CP machines while current replica < desired replica);
It also introduces opt-in control of remediation retry behavior.
Which issue(s) this PR fixes:
Rif #7496