Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Add configurable etcd call timeout #7841

Merged
merged 1 commit into from
Jan 18, 2023
Merged

🌱 Add configurable etcd call timeout #7841

merged 1 commit into from
Jan 18, 2023

Conversation

jelmersnoeck
Copy link
Contributor

What this PR does / why we need it:

Add configurable call timeouts to the etcd client through context deadlines. This is different than the dial timeout, which is only used to establish the connection from the client to the server.

This avoids a stuck reconciliation loop when there is an unresponsive call to the server.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @jelmersnoeck!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @jelmersnoeck. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 3, 2023
@sbueringer
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 4, 2023
@sbueringer
Copy link
Member

/retest

1 similar comment
@jelmersnoeck
Copy link
Contributor Author

/retest

@vincepri
Copy link
Member

vincepri commented Jan 5, 2023

/test pull-cluster-api-e2e-informing-main

@vincepri
Copy link
Member

vincepri commented Jan 5, 2023

/lgtm

1 similar comment
@vincepri
Copy link
Member

vincepri commented Jan 5, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ca6a4d0c1604b67c295476246398066ff6595293

@sbueringer
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 16, 2023
@k8s-ci-robot k8s-ci-robot requested a review from vincepri January 16, 2023 23:10
@jelmersnoeck jelmersnoeck force-pushed the configure-etcd-call-timeout branch from 8e35292 to 6fdd0a5 Compare January 16, 2023 23:11
sbueringer
sbueringer reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx! Last nit, otherwise lgtm from my side

controlplane/kubeadm/internal/etcd/etcd_test.go Outdated Show resolved Hide resolved
@jelmersnoeck jelmersnoeck force-pushed the configure-etcd-call-timeout branch from 6fdd0a5 to 878c8f6 Compare January 17, 2023 12:20
Add configurable etcd call timeout
d9dbca5 
Add configurable call timeouts to the etcd client through context
deadlines. This is different than the dial timeout, which is only used
to establish the connection from the client to the server.

This avoids a stuck reconciliation loop when there is an unresponsive
call to the server.
@jelmersnoeck jelmersnoeck force-pushed the configure-etcd-call-timeout branch from 878c8f6 to d9dbca5 Compare January 17, 2023 15:53
@sbueringer
Copy link
Member

Thank you!

/lgtm
/test pull-cluster-api-e2e-full-main

/assign @vincepri

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9a010f6af9c2e401bbddc7aa4f88a2b4307654d9

@vincepri
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 18, 2023
@k8s-ci-robot k8s-ci-robot merged commit e274f44 into kubernetes-sigs:main Jan 18, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 18, 2023
@jelmersnoeck jelmersnoeck deleted the configure-etcd-call-timeout branch January 18, 2023 21:26
@huaqing1994 huaqing1994 mentioned this pull request Feb 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@vincepri vincepri

@sbueringer sbueringer

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
4 participants
@jelmersnoeck @k8s-ci-robot @sbueringer @vincepri