-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 book: drop outdated note about removed e2e test func #7817
📖 book: drop outdated note about removed e2e test func #7817
Conversation
Signed-off-by: Stefan Büringer [email protected]
@@ -77,16 +77,6 @@ This method: | |||
- Waits for the providers controllers to be running. | |||
- Creates log watchers for all the providers | |||
|
|||
<aside class="note"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know when it has been removed, but it doesn't exist anymore
nice catch! |
LGTM label has been added. Git tree hash: 2cb44ff248472678d70d9caa58cbd735b5a3c0df
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.3 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
not sure if we should cherry pick also in 1.2 |
@fabriziopandini: new pull request created: #7818 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
I would personally only backport the book into 1.2 for must-have documentation updates (I'm assuming that most users only read our "current' book). But absolutely no objections if you want to. |
I kind of agree, but unfortunately, we don't have currently a good definition of "must-have documentation updates". |
Good point. I'll think about it and open a follow-up issue or PR. I think there also might be a difference between:
But probably doesn't help as it makes it more complicated if we differentiate between those cases in our policy :) |
@fabriziopandini sorry edited my comment while you were reading it :) |
@sbueringer PTAL #7823 |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #