Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 book: drop outdated note about removed e2e test func #7817

Merged

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 2, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 2, 2023
@@ -77,16 +77,6 @@ This method:
- Waits for the providers controllers to be running.
- Creates log watchers for all the providers

<aside class="note">
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know when it has been removed, but it doesn't exist anymore

@fabriziopandini
Copy link
Member

nice catch!
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2cb44ff248472678d70d9caa58cbd735b5a3c0df

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 2, 2023
@fabriziopandini
Copy link
Member

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini
Copy link
Member

not sure if we should cherry pick also in 1.2
@sbueringer ?

@k8s-infra-cherrypick-robot

@fabriziopandini: new pull request created: #7818

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer sbueringer deleted the pr-drop-outdated-note branch January 2, 2023 15:19
@sbueringer
Copy link
Member Author

sbueringer commented Jan 2, 2023

not sure if we should cherry pick also in 1.2 @sbueringer ?

I would personally only backport the book into 1.2 for must-have documentation updates (I'm assuming that most users only read our "current' book). But absolutely no objections if you want to.

@fabriziopandini
Copy link
Member

I would personally only backport the book into 1.2 for must-have documentation updates (I'm assuming that most users only read our "current' book). But absolutely no objections if you want to.

I kind of agree, but unfortunately, we don't have currently a good definition of "must-have documentation updates".
might be it will be enough to specify in our backport policies that we backport document changes only to the current version of the book (backport to older releases can be exceptionally approved by maintainers under case-by-case evaluation), or something similar

@sbueringer
Copy link
Member Author

sbueringer commented Jan 2, 2023

Good point.

I'll think about it and open a follow-up issue or PR.

I think there also might be a difference between:

  • the kind of changes we (as maintainers) kind of guarantee that we cherry-pick automatically vs.
  • the kind of backports we would merge if someone opens a PR for it

But probably doesn't help as it makes it more complicated if we differentiate between those cases in our policy :)

@sbueringer
Copy link
Member Author

sbueringer commented Jan 2, 2023

@fabriziopandini sorry edited my comment while you were reading it :)

@fabriziopandini
Copy link
Member

@sbueringer PTAL #7823

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants