Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 ClusterClass proposal: Clean up outdated implementation details by linking the book's page #7790

Merged
merged 1 commit into from
Jan 19, 2023
Merged

🌱 ClusterClass proposal: Clean up outdated implementation details by linking the book's page #7790

merged 1 commit into from
Jan 19, 2023

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Dec 21, 2022 •
edited
Loading

What this PR does / why we need it:
As we already did for other proposals, this PR cleaned up the ClusterClass proposal removing outdated/hard-to-maintain implementation details by linking the book's page

This will hopefully make it easier to maintain the document up to date in future

Fixes: #5753

@k8s-ci-robot k8s-ci-robot requested a review from oscr December 21, 2022 11:47
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 21, 2022
ykakarap
ykakarap reviewed Dec 22, 2022
View reviewed changes
Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Nice work!

docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2022
@fabriziopandini fabriziopandini force-pushed the cleanup-clusterclass-proposal branch from 55d6cfb to f3e36d8 Compare December 29, 2022 16:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 29, 2022
@fabriziopandini
Copy link
Member Author

@killianmuldoon @sbueringer PTAL

sbueringer
sbueringer reviewed Jan 10, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for working on this.

A few nits, otherwise lgtm

docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
@fabriziopandini fabriziopandini force-pushed the cleanup-clusterclass-proposal branch from f3e36d8 to 4f242a6 Compare January 11, 2023 15:24
@fabriziopandini
Copy link
Member Author

@sbueringer comment addressed, rebased and squashed

@sbueringer
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 11, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0901e4692864b3b6695d255be0853b33332f77ca

killianmuldoon
killianmuldoon approved these changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

docs/proposals/20210526-cluster-class-and-managed-topologies.md Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 19, 2023
@k8s-ci-robot k8s-ci-robot merged commit 0b95966 into kubernetes-sigs:main Jan 19, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jan 19, 2023
@fabriziopandini fabriziopandini deleted the cleanup-clusterclass-proposal branch January 30, 2023 09:38
@oscr
Copy link
Contributor

oscr commented Mar 25, 2023

@fabriziopandini Question for the 1.4 release notes: should this maybe be a 📝 (proposal) rather than 🌱?

@fabriziopandini
Copy link
Member Author

I think not, it is just reshuffling things but it isn't adding or changing anything

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ykakarap ykakarap ykakarap left review comments

@sbueringer sbueringer sbueringer left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@oscr oscr Awaiting requested review from oscr

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.

Reduce detail in ClusterClass proposal validation
6 participants
@fabriziopandini @sbueringer @k8s-ci-robot @oscr @ykakarap @killianmuldoon