Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Cluster topology: fix comment about MD replicas defaulting #7779

Merged
merged 1 commit into from
Dec 22, 2022
Merged

🌱 Cluster topology: fix comment about MD replicas defaulting #7779

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/v1beta1/cluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ type MachineDeploymentTopology struct {
FailureDomain *string `json:"failureDomain,omitempty"`

// Replicas is the number of worker nodes belonging to this set.
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to zero)
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to 1)
// and it's assumed that an external entity (like cluster autoscaler) is responsible for the management
// of this value.
// +optional
Expand Down
2 changes: 1 addition & 1 deletion api/v1beta1/zz_generated.openapi.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions config/crd/bases/cluster.x-k8s.io_clusters.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion docs/proposals/20210526-cluster-class-and-managed-topologies.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ Note: Builtin variables are defined in [Builtin variables](#builtin-variables) b
Name string `json:"name"`
// The number of worker nodes belonging to this set.
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to zero)
// If the value is nil, the MachineDeployment is created without the number of Replicas (defaulting to 1)
// and it's assumed that an external entity (like cluster autoscaler) is responsible for the management
// of this value.
// +optional
Expand Down
2 changes: 1 addition & 1 deletion docs/proposals/images/runtime-hooks/runtime-hooks-openapi.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,7 +525,7 @@ components:
replicas:
description: Replicas is the number of worker nodes belonging to this set.
If the value is nil, the MachineDeployment is created without the number
of Replicas (defaulting to zero) and it's assumed that an external entity
of Replicas (defaulting to 1) and it's assumed that an external entity
(like cluster autoscaler) is responsible for the management of this value.
format: int32
type: integer
Expand Down