Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] 🐛 Validate MachineDeploymentTopology.Name to be valid label value #7762

Merged
merged 1 commit into from
Dec 14, 2022
Merged

[release-1.2] 🐛 Validate MachineDeploymentTopology.Name to be valid label value #7762

merged 1 commit into from
Dec 14, 2022

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #7759

/assign ykakarap

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Dec 14, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 14, 2022
Merged
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 14, 2022
killianmuldoon
killianmuldoon approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 14, 2022
@killianmuldoon
Copy link
Contributor

/hold
After discussing this with @fabriziopandini we realized this really needs to validate the name generation for MDs, not just the name passed in the Cluster object.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2022
@fabriziopandini
Copy link
Member

/hold cancel
After digging into the codebase we confirmed this one is a valid check because the MD name is used as a value for topology.cluster.x-k8s.io/deployment-name.

/retest

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 14, 2022
@fabriziopandini
Copy link
Member

/check-CLA

@fabriziopandini
Copy link
Member

/easycla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 14, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit 43b35ba into kubernetes-sigs:release-1.2 Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@fabriziopandini fabriziopandini

@ykakarap ykakarap

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
5 participants
@k8s-infra-cherrypick-robot @killianmuldoon @fabriziopandini @k8s-ci-robot @ykakarap