[release-1.2] 🌱 Bump shellcheck version (0.7.0 -> 0.9.0)

[killianmuldoon]

This is a manual cherry-pick of #7737
What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[ykakarap]

/test pull-cluster-api-verify-release-1-2

[killianmuldoon]

Unfortunately the issue on this one isn't a flake - just digging into it now.

[fabriziopandini]

/retest

[oscr]

There is a diff between 1.2 and main. But it's strange this would cause it to fail: git diff origin/release-1.2 main -- hack/ensure-golangci-lint.sh

[oscr]

@killianmuldoon @fabriziopandini @ykakarap I think I've found the issue by enabling tracing in main:

+ '[' 1 -ne 1 ']'
+ VERSION=v0.9.0
+ OS=unknown
+ [[ linux-gnu == \l\i\n\u\x* ]]
+ OS=linux
++ dirname ./hack/verify-shellcheck.sh
+ source ./hack/utils.sh
++ get_root_path
++ git rev-parse --show-toplevel
+ ROOT_PATH=/home/oscaru/go/src/k8s.io/kubernetes-sig/cluster-api
++ mktemp -d
+ TMP_DIR=/tmp/tmp.b77fDUlRC4
+ OUT=/tmp/tmp.b77fDUlRC4/out.log
+ trap cleanup EXIT
++ dirname ./hack/verify-shellcheck.sh
+ SHELLCHECK=././hack/tools/bin/shellcheck/v0.9.0/shellcheck
+ '[' '!' -f ././hack/tools/bin/shellcheck/v0.9.0/shellcheck ']'
+ echo 'Running shellcheck...'
Running shellcheck...
+ cd /home/oscaru/go/src/k8s.io/kubernetes-sig/cluster-api
++ find . -name '*.sh'
++ grep tilt_modules
+ IGNORE_FILES=
+ cleanup
+ ret=0
+ [[ -s /tmp/tmp.b77fDUlRC4/out.log ]]
+ echo 'Cleaning up...'
Cleaning up...
+ rm -rf /tmp/tmp.b77fDUlRC4
+ exit 0

Need to run and do some shopping but will look at it asap.

[oscr]

Can recreate now on main. Fix in progress.

[furkatgofurov7]

/retest

[furkatgofurov7]

@killianmuldoon test pull-cluster-api-verify-release-1-2 needs a fix apparently

 Running shellcheck...
Ignoring shellcheck on ./third_party/japaric-trust/crate_install.sh
Found errors:
In ./hack/ensure-golangci-lint.sh line 167:
  echo "$0"
  ^-------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly).
In ./hack/ensure-golangci-lint.sh line 230:
  echo ${arch}
       ^-----^ SC2086 (info): Double quote to prevent globbing and word splitting.
Did you mean: 
  echo "${arch}" 

Edit: Looks like this is waiting for other fix (7755) to land first

[sbueringer]

@killianmuldoon Should this be unblocked now as #7757 seems to be merged?

[oscr]

/lgtm

[sbueringer]

Thx!

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment