Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.2] 🐛 releaselink: fix goproxy to also return versions for major > 1 #7729

Merged
merged 1 commit into from
Dec 13, 2022
Merged

[release-1.2] 🐛 releaselink: fix goproxy to also return versions for major > 1 #7729

merged 1 commit into from
Dec 13, 2022

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented Dec 12, 2022 •
edited
Loading

What this PR does / why we need it:

  • Fixes goproxy for releaselink to also list versions > v1

Cherry-picks #7709 for releaselink only

cc @fabriziopandini

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Dec 12, 2022
killianmuldoon
killianmuldoon reviewed Dec 12, 2022
View reviewed changes
cmd/clusterctl/client/config/cert_manager.go Outdated
@@ -19,7 +19,7 @@ package config
// CertManager defines cert-manager configuration.
type CertManager interface {
// URL returns the name of the cert-manager repository.
// If empty, "https://github.com/cert-manager/cert-manager/releases/latest/cert-manager.yaml" will be used.
// If empty, "https://github.com/cert-manager/cert-manager/releases/{DefaultVersion}/cert-manager.yaml" will be used.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this change related to the goproxy changes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not directly, but was included in the first PR
Due to the first commit which is required in order to apply the second one.

Original change was at #7192

@fabriziopandini
Copy link
Member

/hold
I think we should backport only the fix for release link, not the clusterctl part of this PR

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 12, 2022
@chrischdi
releaselink: fix goproxy to also return versions for major > 1
0aed307 
Also:
* moves goproxy functionality to an internal package
* fixes releaselink references for aws
@chrischdi
Copy link
Member Author

Adjusted to only backport the fix for releaselink.

@chrischdi chrischdi changed the title [release-1.2] 🐛 clusterctl: fix goproxy to also return versions for major > 1 [release-1.2] 🐛 releaselink: fix goproxy to also return versions for major > 1 Dec 13, 2022
@chrischdi chrischdi force-pushed the cp-1-2/clusterctl-goproxy branch from 9408f4d to 0aed307 Compare December 13, 2022 07:34
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 13, 2022
@fabriziopandini
Copy link
Member

Great job!
/hold cancel
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2022
@k8s-ci-robot k8s-ci-robot merged commit f58a06c into kubernetes-sigs:release-1.2 Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @fabriziopandini @k8s-ci-robot @killianmuldoon