Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Fix broken links in book #7726

Merged
merged 1 commit into from
Dec 12, 2022
Merged

📖 Fix broken links in book #7726

merged 1 commit into from
Dec 12, 2022

Conversation

killianmuldoon
Copy link
Contributor

Signed-off-by: killianmuldoon [email protected]

Fix two of broken links in the book.

@killianmuldoon
Fix broken links in book
1a2bbc6 
Signed-off-by: killianmuldoon <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 12, 2022
killianmuldoon
killianmuldoon commented Dec 12, 2022
View reviewed changes
Copy link
Contributor Author

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cherry-pick release-1.3

@killianmuldoon killianmuldoon changed the title Fix broken links in book 📖 Fix broken links in book Dec 12, 2022
oscr
oscr approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@oscr oscr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great find!

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 12, 2022
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 12, 2022
@fabriziopandini
Copy link
Member

@killianmuldoon @oscr should we backport this fix? if yes, up to which version?

@killianmuldoon
Copy link
Contributor Author

I've got a cherry-pick open for 1.3 - I think for book nits updating the mainline version is probably sufficient unless it's something major - do you think we should also cherry pick to 1.2?

@k8s-ci-robot k8s-ci-robot merged commit 779c9ba into kubernetes-sigs:main Dec 12, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Dec 12, 2022
@killianmuldoon
Copy link
Contributor Author

/cherry-pick release-1.3

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Dec 12, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #7732

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/test ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oscr oscr oscr approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@oscr oscr

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@killianmuldoon @fabriziopandini @k8s-ci-robot @k8s-infra-cherrypick-robot @oscr