-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Add name hashing for long MS and KCP names #7711
🐛 Add name hashing for long MS and KCP names #7711
Conversation
1c2e134
to
520d3b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 on getting this change in, seems a fine addition!
840523c
to
068c239
Compare
782744d
to
8160de6
Compare
/test pull-cluster-api-e2e-full-main |
31ad451
to
3fea53d
Compare
Signed-off-by: killianmuldoon <[email protected]>
3fea53d
to
fca87be
Compare
/lgtm |
/lgtm |
Great work! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.3 |
@killianmuldoon: #7711 failed to apply on top of branch "release-1.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
@killianmuldoon: #7711 failed to apply on top of branch "release-1.3":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon [email protected]
Add a function which hashes the MachineSet and KubeadmControlPlane name for use in a label if the name is too long to be used as a normal label value.
Part of #7710