🐛 Fix unit test coverage in KubeadmConfig #7678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/M
killianmuldoon
force-pushed
the
fix-kubadmconfig-tests
branch
from
aed0ce2 to
940d233
Compare
k8s-ci-robot
added
size/L
|
/retest |
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
killianmuldoon
commented
Jan 18, 2023
| @@ -92,11 +92,17 @@ func TestKubeadmConfigReconciler_MachineToBootstrapMapFuncReturn(t *testing.T) { | |||
| // Reconcile returns early if the kubeadm config is ready because it should never re-generate bootstrap data. | |||
| func TestKubeadmConfigReconciler_Reconcile_ReturnEarlyIfKubeadmConfigIsReady(t *testing.T) { | |||
| g := NewWithT(t) | |||
|
|
|||
There was a problem hiding this comment.
The intention here was to ensure that the tests were actually testing conditions resulting from reconcile, rather than just the controller runtime result. Overall package test coverage goes from 68.8 -> 71.1 with these changes.
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
fix-kubadmconfig-tests
branch
from
940d233 to
484b4cf
Compare
sbueringer
reviewed
Jan 19, 2023
|
/lgtm /assign @fabriziopandini |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: bc12956dc7a988ccf27cd4dab8f389fbcca8a4b8
|
|
Let's move on, we can follow-up if anyone has further comments /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: killianmuldoon [email protected]
A number of the tests in the kubeadmconfig controller were testing insufficient conditions, and some were not testing what they intended to.
This PR is a first round of fixing up the test coverage.