🐛 Fix bug in kubeadmconfig adoption #7623
Conversation
k8s-ci-robot
added
cncf-cla: yes
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
Outdated
Show resolved
Hide resolved
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
fix/ownerref-bug
branch
from
29da46f to
6658066
Compare
k8s-ci-robot
added
size/L
killianmuldoon
changed the title
killianmuldoon
force-pushed
the
fix/ownerref-bug
branch
from
6658066 to
8f0f7d3
Compare
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_test.go
Outdated
Show resolved
Hide resolved
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller.go
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
fix/ownerref-bug
branch
from
8f0f7d3 to
b339d65
Compare
bootstrap/kubeadm/internal/controllers/kubeadmconfig_controller_test.go
Outdated
Show resolved
Hide resolved
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
fix/ownerref-bug
branch
from
b339d65 to
794f6c1
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/cherry-pick release-1.3 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.2 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Thx for the quick fix! |
|
/hold Feel free to merge |
k8s-ci-robot
added
the
do-not-merge/hold
|
/remove-hold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
@sbueringer: new pull request created: #7626 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sbueringer: new pull request created: #7627 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: killianmuldoon [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #