✨ Introduce additional linters & bump golangci-lint to 1.50.1

[Prajyot-Parab]

Signed-off-by: Prajyot-Parab [email protected]

What this PR does / why we need it:

• Introduce additional linters & bump golangci-lint to 1.50.1

Here are the descriptions of the new linters this PR proposes to add:

• decorder: check declaration order and count of types, constants, variables and functions [fast: true, auto-fix: false]
• execinquery: execinquery is a linter about query string checker in Query function which reads your Go src files and warning it finds [fast: false, auto-fix: false]
• nosprintfhostport: Checks for misuse of Sprintf to construct a host with port in a URL. [fast: true, auto-fix: false]
• reassign: Checks that package variables are not reassigned [fast: false, auto-fix: false]
• usestdlibvars: A linter that detect the possibility to use variables/constants from the Go standard library. [fast: true, auto-fix: false]

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[fabriziopandini]

+1 from my side
@oscr @sbueringer who did recent work in this area

[killianmuldoon]

Thanks for the contribution @Prajyot-Parab 😃

IMO it would be better not to include execinquery and decorder in this PR, but it would be great to see a discussion in a new PR about how to implement the rules in decorder in CAPI.

It would be awesome if you could enable a pattern in the settings for reassign and fix the findings in this PR though!

[oscr]

I agree with @killianmuldoon summary.

@Prajyot-Parab Thank you for your help. There are some good checks here that we are missing.

[oscr]

Thank you for helping us explore the vast area of linters!

/lgtm

[killianmuldoon]

Thanks for making the changes!

/lgtm

[sbueringer]

Thx @Prajyot-Parab

Can you please update the PR description to reflect the linters that were eventually added via this PR?

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment