Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Update support policy #7549

Merged
merged 1 commit into from
Nov 18, 2022
Merged

✨ Update support policy #7549

merged 1 commit into from
Nov 18, 2022

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
With this PR we prevent suddenly dropping support for the current CAPI minor release when a new one is created
Note: we are going to support n and n-1 only for the current API version, while for the older API version we are going to support only a minor release

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 16, 2022
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 16, 2022
@dlipovetsky
Copy link
Contributor

+1

Just for reference, this is the same support model used by Fedora Linux.

CecileRobertMichon
CecileRobertMichon reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

We've talked about doing something like this in the past and I believe it's the right way to go

/lgtm

/cc @kubernetes-sigs/cluster-api-release-team

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 16, 2022
@sbueringer
Copy link
Member

+1 as well

/lgtm

@oscr
Copy link
Contributor

oscr commented Nov 16, 2022

+1 Thank you for this clarification!

/lgtm

@nawazkh
Copy link
Member

nawazkh commented Nov 17, 2022

+1 on this addition. Thank you!
/lgtm

@sbueringer
Copy link
Member

/cherry-pick release-1.3

As discussed yesterday in the office hours, the idea is to apply this policy the first time for the v1.3 release. (so it would be good to also have it documented like that in the v1.3. book)

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

As discussed yesterday in the office hours, the idea is to apply this policy the first time for the v1.3 release. (so it would be good to also have it documented like that in the v1.3. book)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

furkatgofurov7
furkatgofurov7 reviewed Nov 17, 2022
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

Small nit inline

CONTRIBUTING.md Outdated Show resolved Hide resolved
cpanato
cpanato approved these changes Nov 17, 2022
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 as well
/lgtm

@dntosas
Copy link
Contributor

dntosas commented Nov 17, 2022

+1 from here also

/lgtm

killianmuldoon
killianmuldoon approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny nit - otherwise

/lgtm

CONTRIBUTING.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
killianmuldoon
killianmuldoon approved these changes Nov 18, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
@hackeramitkumar
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2022
@cpanato
Copy link
Member

cpanato commented Nov 18, 2022

/lgtm

@sbueringer
Copy link
Member

My bad, deleted the branch from my fork too early so linkchecker was broken

Should work now

@k8s-ci-robot k8s-ci-robot merged commit c148261 into kubernetes-sigs:main Nov 18, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Nov 18, 2022
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Nov 18, 2022
Merged
@k8s-infra-cherrypick-robot
Copy link

@sbueringer: new pull request created: #7568

In response to this:

/cherry-pick release-1.3

As discussed yesterday in the office hours, the idea is to apply this policy the first time for the v1.3 release. (so it would be good to also have it documented like that in the v1.3. book)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the update-support-policy branch November 21, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@CecileRobertMichon CecileRobertMichon CecileRobertMichon left review comments

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@cpanato cpanato cpanato approved these changes

@sbueringer sbueringer Awaiting requested review from sbueringer

@vincepri vincepri Awaiting requested review from vincepri

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@oscr oscr

@cpanato cpanato

@sbueringer sbueringer

@CecileRobertMichon CecileRobertMichon

@dntosas dntosas

@nawazkh nawazkh

@killianmuldoon killianmuldoon

@hackeramitkumar hackeramitkumar

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.