🐛 logging: Avoid adding multiple objects to the same logger in for loops

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Was debugging ClusterCacheTracker and found log statements with 20 Machines as k/v pairs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

/assign @fabriziopandini @killianmuldoon

[killianmuldoon]

/lgtm

[fabriziopandini]

nice catch
/lgtm

[fabriziopandini]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

Let's cherry-pick this bugfix as well

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@sbueringer: #7534 failed to apply on top of branch "release-1.2":

Applying: logging: Avoid adding multiple objects to the same logger in for loops
Using index info to reconstruct a base tree...
M	controlplane/kubeadm/internal/controllers/controller.go
M	internal/controllers/machine/machine_controller.go
M	internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
M	internal/controllers/machineset/machineset_controller.go
M	internal/controllers/topology/cluster/patches/engine.go
M	test/extension/handlers/topologymutation/handler.go
Falling back to patching base and 3-way merge...
Auto-merging test/extension/handlers/topologymutation/handler.go
CONFLICT (content): Merge conflict in test/extension/handlers/topologymutation/handler.go
Auto-merging internal/controllers/topology/cluster/patches/engine.go
Auto-merging internal/controllers/machineset/machineset_controller.go
CONFLICT (content): Merge conflict in internal/controllers/machineset/machineset_controller.go
Auto-merging internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
CONFLICT (content): Merge conflict in internal/controllers/machinedeployment/machinedeployment_rollout_ondelete.go
Auto-merging internal/controllers/machine/machine_controller.go
CONFLICT (content): Merge conflict in internal/controllers/machine/machine_controller.go
Auto-merging controlplane/kubeadm/internal/controllers/controller.go
CONFLICT (content): Merge conflict in controlplane/kubeadm/internal/controllers/controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 logging: Avoid adding multiple objects to the same logger in for loops
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

Let's cherry-pick this bugfix as well

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

Took a closer look. Looks like this cherry-pick doesn't make sense as the issues don't exist on release-1.2 as we only made the log changes (that introduced the issues) on main.