-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Improved the usage to reflect the required arguments in generate cluster
, describe cluster
and get kubeconfig
#7522
🌱 Improved the usage to reflect the required arguments in generate cluster
, describe cluster
and get kubeconfig
#7522
Conversation
Signed-off-by: Chirayu Kapoor <[email protected]>
Welcome @chiukapoor! |
Hi @chiukapoor. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Great work @chiukapoor! This looks good to me! /lgtm New output:
|
thanks @chiukapoor for this nice PR, looking forward to seeing more of your work! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Approved GitHub actions to run manually now. |
Signed-off-by: Chirayu Kapoor [email protected]
What this PR does / why we need it:
For example when running
clusterctl generate cluster --help
, usage is described as:However, if you attempt to run the given example you will get an error.
Since the command has a required argument, updated the usage to reflect the required arguments. For example:
Similar improvement has been applied in the usage text of
generate cluster
,describe cluster
andget kubeconfig
Which issue(s) this PR fixes:
Fixes #6867