-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Get Ginkgo version in Makefile from go.mod #7503
✨ Get Ginkgo version in Makefile from go.mod #7503
Conversation
Skipping CI for Draft Pull Request. |
/test all |
d7ad76f
to
faa7575
Compare
/retest |
cc @sbueringer Semi related to the discussion about make. A wild idea to get the version from |
faa7575
to
b4f1209
Compare
/retest |
@oscr Somehow missed this PR entirely. GIven that we recently forgot to bump the ginkgo binary when we bumped the dependency... I'm in favor of this PR as to me it's a good incremental improvement to guarantee versions are sync |
b4f1209
to
cfc1b67
Compare
Thx! /lgtm /assign @fabriziopandini |
Thanks for proposing this change @oscr, nice idea! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
What this PR does / why we need it:
Exploring a way to avoid having to hardcode dependency versions in the Makefile that already exist in
go.mod
.This would allow having dependabot bump these dependencies automatically to get a) notification of new versions b) knowledge of breakage asap.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #