-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add release tasks doc and corresponding issue template #7499
📖 Add release tasks doc and corresponding issue template #7499
Conversation
ec3322f
to
4039ad9
Compare
@ykakarap @dntosas @cpanato @hackeramitkumar @CecileRobertMichon @enxebre @fabriziopandini @vincepri Hey folks, please take a look :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for putting this together!
I just have one request to update my slack user ID in the doc below :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is outstanding work, kudos!
only a few nits from my side.
@ykakarap let's make sure all the folks in the release team take a look at this PR, but also that everyone is aware that we can improve this iteratively in follow up PRs
cc @kubernetes-sigs/cluster-api-release-team |
Fixed some of the easier findings. Will push another commit with the ones that take more time soon. |
cc @joekr (PTAL :)) |
Thank you very much for the reviews. All findings should be addressed or answered. I updated the example issue accordingly:
Also testing the process for v1.3: #7527 (as applicable) |
/lgtm |
@sbueringer , Before merging this PR , we should squash the commits to a single commit. |
Will do, just waiting to get the conversations above resolved and consensus. Then it's a quick squash + lgtm/approve. |
/lgtm I think this is a great start, huge thank you @sbueringer for putting this together so thoroughly and eloquently 💯 This will be a living doc and the release team and docs manager (@oscr 👀) can keep improving it as we go but I'm in favor of merging this for now so we have it in place for the v1.4 release cycle start. |
thnx for your effort @sbueringer , nice and essential work 🚀 |
62de78e
to
f0ee035
Compare
Everything should be adressed now + squashed:
Thx for the reviews :) |
Given all the lgtm's above I would merge this relatively soon |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold |
Thx! |
/hold cancel |
/cherry-pick release-1.3 |
@sbueringer: new pull request created: #7563 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Let's ignore the markdown checker. The links won't actually be broken after merge.
Examples:
Part of #7389